rlishtaba / rubyripper

Automatically exported from code.google.com/p/rubyripper
0 stars 0 forks source link

WARNING: Encoding to mp3 exited with an error with track #429

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago
What steps will reproduce the problem?
1. put settings to rip to mp3
2. put any audio cd in the drive
3. rrip_cli

I get no crash and rubyripper finishes, but no mp3 files are created.

the important part of the log (verbose+debug) is:

Adding track 1 (mp3) to the queue..
command = flac --best -V -o "/var/data/music/in/flac/Massive
Attack/Collected/01 - Massive Attack - Safe From Harm.flac" --tag
ALBUM="Collected" --tag DATE="2006" --tag GENRE="Unknown" --tag
DISCID="c812730e" --tag ARTIST="Massive Attack" --tag TITLE="Safe From
Harm" --tag TRACKNUMBER=1 --tag TRACKTOTAL=14
"/var/data/music/in/flac/Massive Attack/temp_sr0/track1_1.wav"

flac 1.2.1, Copyright (C) 2000,2001,2002,2003,2004,2005,2006,2007  Josh Coalson
flac comes with ABSOLUTELY NO WARRANTY.  This is free software, and you are
welcome to redistribute it under certain conditions.  Type `flac' for details.

track1_1.wav: Verify OK, wrote 37927653 bytes, ratio=0.673
Encoding progress (25.2 %)
Removing track 1 (flac) from the queue..
Ripping track 2
Expected filesize for track 2       is 55389644 bytes.
Free disk space is 61253280 MB
Minutes ripping is 3.1088554184499997.
Starting to rip track 2, trial #1cdparanoia [.23962]-[.23549] -d /dev/cdrom
-O 6 "/var/data/music/in/flac/Massive Attack/temp_sr0/track2_1.wav"
command = 
nice: a command must be given with an adjustment
Try `nice --help' for more information.
cdparanoia III release 10.2 (September 11, 2008)

WARNING: Encoding to mp3 exited with an error with track 1!
Encoding progress (50.4 %)
Removing track 1 (mp3) from the queue..

So encoding to flac works, mp3 encoding starts, the corresponding command
is empty, nice complains and no mp3 file is actually created.

This has in itself nothing to do with UTF. The release has only ascii
characters in artist, release title and title.
However it is probably connected to the fixes for
http://code.google.com/p/rubyripper/issues/detail?id=428 because it was
working before.

Original issue reported on code.google.com by goo...@JonnyJD.net on 31 May 2010 at 9:03

GoogleCodeExporter commented 8 years ago
I wonder if you already got last update. I can't reproduce the problem here.

Original comment by boukewou...@gmail.com on 31 May 2010 at 9:11

GoogleCodeExporter commented 8 years ago
By the way, I think I communicate less with the average person working besides 
me ;) 
That's just great :D

Original comment by boukewou...@gmail.com on 31 May 2010 at 9:13

GoogleCodeExporter commented 8 years ago
This is without
http://github.com/rubyripperdev/rubyripper/commit/ac30a1c90739cb17c0e51a873b0cf1
9f15c3e140

I am trying with this commit right now.

Original comment by goo...@JonnyJD.net on 31 May 2010 at 9:14

GoogleCodeExporter commented 8 years ago
Now I get this:

Ripping progress (100 %)
Adding track 2 (flac) to the queue..
Adding track 2 (mp3) to the queue..
command = 
nice: a command must be given with an adjustment
Try `nice --help' for more information.
command = 
nice: a command must be given with an adjustment
WARNING: Encoding to flac exited with an error with track 2!
Try `nice --help' for more information.
WARNING: Encoding to mp3 exited with an error with track 2!
/var/data/music/in/flac/Massive Attack/Collected#1/*.flac: ERROR: reading 
metadata,
status = "FLAC__METADATA_CHAIN_STATUS_ERROR_OPENING_FILE"

The FLAC file could not be opened.  Most likely the file does not exist
or is not readable.
Encoding progress (75.2 %)
Removing track 2 (flac) from the queue..
Encoding progress (100 %)
Removing track 2 (mp3) from the queue..
Inside the finished function
Encoding progress (100 %)

So what am I doing differently? I do automatic folder renaming (because I try 
one
release several times without deleting stuff in between and want to keep every
result). I rip to flac and mp3.

Maybe the problem now is the
LC_ALL=C
I put in front. I remember having problems with that. I will try with 
LANG=en_US.UTF-8

Original comment by goo...@JonnyJD.net on 31 May 2010 at 9:26

GoogleCodeExporter commented 8 years ago
Maybe try to update to:
http://github.com/rubyripperdev/rubyripper/commit/ead5d4f8927f0bbd6dbd22c49ed8c9
0f2ebd
be86

Seems like I forgot to actually force the outputted command to be UTF-8 as well.

Original comment by boukewou...@gmail.com on 31 May 2010 at 9:34

GoogleCodeExporter commented 8 years ago
Nope still the same problem

Ripping progress (100 %)
Adding track 2 (flac) to the queue..
Adding track 2 (mp3) to the queue..
command = 
command = 
nice: a command must be given with an adjustment
Try `nice --help' for more information.
WARNING: Encoding to flac exited with an error with track 2!
nice: a command must be given with an adjustment
Try `nice --help' for more information.
WARNING: Encoding to mp3 exited with an error with track 2!
/var/data/music/in/flac/Massive Attack/Collected#3/*.flac: ERROR: reading 
metadata,
status = "FLAC__METADATA_CHAIN_STATUS_ERROR_OPENING_FILE"

The FLAC file could not be opened.  Most likely the file does not exist
or is not readable.
Encoding progress (75.2 %)
Removing track 2 (flac) from the queue..
Encoding progress (100 %)
Removing track 2 (mp3) from the queue..
Inside the finished function
Encoding progress (100 %)

started with
LANG=en_US.UTF-8 rrip_cli

Both commands are empty now (command = )
And you don't have any problems?

Maybe this is another ruby issue now. I am running ruby-svn 26652-2,
which names itself:
$ ruby --version
ruby 1.9.3dev (2010-05-25 trunk 28010) [x86_64-linux]

It should be possible to find out where the command "vanishes". It has 
something to
do with the last few commits.
But I don't have time to dive into the code today. Still have some stuff to do.

I delete all temporary Massive Attack folders and all cached cddb entries and 
try
without any LANG change. I don't think this will make a difference, but I will 
tell
if it does.

Original comment by goo...@JonnyJD.net on 31 May 2010 at 10:07

GoogleCodeExporter commented 8 years ago
This will have to wait until the weekend then, since I will be busy rest of the 
week.

Original comment by boukewou...@gmail.com on 31 May 2010 at 10:22

GoogleCodeExporter commented 8 years ago
This is very weird since I really cannot reproduce this. So I suspect the ruby 
version is to blame indeed. See the output from the terminal:

status = true
Ripping track 1
Expected filesize for track 1       is 25335788 bytes.
Free disk space is 556535996 MB
Minutes ripping is 0.000255227.
cdparanoia -Z [.0]-[.10771] -d /dev/cdrom -O 0 
"/mnt/data/audio/new/flac/temp_sr0/track1_1.wav" 2>&1
Minutes ripping is 0.240076432966667.
cdparanoia -Z [.0]-[.10771] -d /dev/cdrom -O 0 
"/mnt/data/audio/new/flac/temp_sr0/track1_2.wav" 2>&1
Adding track 1 (flac) to the queue..
Adding track 1 (vorbis) to the queue..
Adding track 1 (mp3) to the queue..
command = oggenc -o "/mnt/data/audio/new/vorbis/System Of A Down (2002) Steal 
This 
Album!/01 - Chic 'N' Stu.ogg" -q 4 -c ALBUM="Steal This Album!" -c DATE="2002" 
-c 
GENRE="Metal" -c DISCID="de0a3310" -c ARTIST="System Of A Down" -c TITLE="Chic 
'N' 
Stu" -c TRACKNUMBER=1 -c TRACKTOTAL=16 
"/mnt/data/audio/new/flac/temp_sr0/track1_1.wav" 2>&1
command = flac --best -V -o "/mnt/data/audio/new/flac/System Of A Down (2002) 
Steal 
This Album!/01 - Chic 'N' Stu.flac" --tag ALBUM="Steal This Album!" --tag 
DATE="2002" 
--tag GENRE="Metal" --tag DISCID="de0a3310" --tag ARTIST="System Of A Down" 
--tag 
TITLE="Chic 'N' Stu" --tag TRACKNUMBER=1 --tag TRACKTOTAL=16 
"/mnt/data/audio/new/flac/temp_sr0/track1_1.wav" 2>&1
Removing track 1 (flac) from the queue..
Ripping track 2
Expected filesize for track 2       is 27125660 bytes.
Free disk space is 556491372 MB
Minutes ripping is 0.493700132116667.
cdparanoia -Z [.10772]-[.11532] -d /dev/cdrom -O 0 
"/mnt/data/audio/new/flac/temp_sr0/track2_1.wav" 2>&1
command = lame -V 3 --id3v2-only --tl "Steal This Album!" --ty "2002" --tg 
"Metal" --
tv TXXX=DISCID="de0a3310" --ta "System Of A Down" --tt "Chic 'N' Stu" --tn 1/16 
"/mnt/data/audio/new/flac/temp_sr0/track1_1.wav" 
"/mnt/data/audio/new/mp3/System Of A 
Down (2002) Steal This Album!/01 - Chic 'N' Stu.mp3" 2>&1
Removing track 1 (vorbis) from the queue..
Minutes ripping is 0.6342433723.
cdparanoia -Z [.10772]-[.11532] -d /dev/cdrom -O 0 
"/mnt/data/audio/new/flac/temp_sr0/track2_2.wav" 2>&1
Removing track 1 (mp3) from the queue..
Adding track 2 (flac) to the queue..
Adding track 2 (vorbis) to the queue..
Adding track 2 (mp3) to the queue..
command = oggenc -o "/mnt/data/audio/new/vorbis/System Of A Down (2002) Steal 
This 
Album!/02 - Innervision.ogg" -q 4 -c ALBUM="Steal This Album!" -c DATE="2002" 
-c 
GENRE="Metal" -c DISCID="de0a3310" -c ARTIST="System Of A Down" -c 
TITLE="Innervision" -c TRACKNUMBER=2 -c TRACKTOTAL=16 
"/mnt/data/audio/new/flac/temp_sr0/track2_1.wav" 2>&1
command = flac --best -V -o "/mnt/data/audio/new/flac/System Of A Down (2002) 
Steal 
This Album!/02 - Innervision.flac" --tag ALBUM="Steal This Album!" --tag 
DATE="2002" 
--tag GENRE="Metal" --tag DISCID="de0a3310" --tag ARTIST="System Of A Down" 
--tag 
TITLE="Innervision" --tag TRACKNUMBER=2 --tag TRACKTOTAL=16 
"/mnt/data/audio/new/flac/temp_sr0/track2_1.wav" 2>&1
Removing track 2 (flac) from the queue..
Ripping track 3
Expected filesize for track 3       is 20620028 bytes.
command = lame -V 3 --id3v2-only --tl "Steal This Album!" --ty "2002" --tg 
"Metal" --
tv TXXX=DISCID="de0a3310" --ta "System Of A Down" --tt "Innervision" --tn 2/16 
"/mnt/data/audio/new/flac/temp_sr0/track2_1.wav" 
"/mnt/data/audio/new/mp3/System Of A 
Down (2002) Steal This Album!/02 - Innervision.mp3" 2>&1
Free disk space is 556464036 MB
Minutes ripping is 0.898375214833333.
cdparanoia -Z [.22305]-[.8766] -d /dev/cdrom -O 0 
"/mnt/data/audio/new/flac/temp_sr0/track3_1.wav" 2>&1
Removing track 2 (vorbis) from the queue..
Minutes ripping is 1.00559688838333.
cdparanoia -Z [.22305]-[.8766] -d /dev/cdrom -O 0 
"/mnt/data/audio/new/flac/temp_sr0/track3_2.wav" 2>&1
Removing track 2 (mp3) from the queue..
Adding track 3 (flac) to the queue..
Adding track 3 (vorbis) to the queue..
Adding track 3 (mp3) to the queue..
command = oggenc -o "/mnt/data/audio/new/vorbis/System Of A Down (2002) Steal 
This 
Album!/03 - Bubbles.ogg" -q 4 -c ALBUM="Steal This Album!" -c DATE="2002" -c 
GENRE="Metal" -c DISCID="de0a3310" -c ARTIST="System Of A Down" -c 
TITLE="Bubbles" -c 
TRACKNUMBER=3 -c TRACKTOTAL=16 "/mnt/data/audio/new/flac/temp_sr0/track3_1.wav" 
2>&1
command = flac --best -V -o "/mnt/data/audio/new/flac/System Of A Down (2002) 
Steal 
This Album!/03 - Bubbles.flac" --tag ALBUM="Steal This Album!" --tag 
DATE="2002" --
tag GENRE="Metal" --tag DISCID="de0a3310" --tag ARTIST="System Of A Down" --tag 
TITLE="Bubbles" --tag TRACKNUMBER=3 --tag TRACKTOTAL=16 
"/mnt/data/audio/new/flac/temp_sr0/track3_1.wav" 2>&1
Removing track 3 (flac) from the queue..
Ripping track 4
Expected filesize for track 4       is 23797580 bytes.
Free disk space is 556449460 MB
Minutes ripping is 1.2061747447.
cdparanoia -Z [.31072]-[.10117] -d /dev/cdrom -O 0 
"/mnt/data/audio/new/flac/temp_sr0/track4_1.wav" 2>&1
command = lame -V 3 --id3v2-only --tl "Steal This Album!" --ty "2002" --tg 
"Metal" --
tv TXXX=DISCID="de0a3310" --ta "System Of A Down" --tt "Bubbles" --tn 3/16 
"/mnt/data/audio/new/flac/temp_sr0/track3_1.wav" 
"/mnt/data/audio/new/mp3/System Of A 
Down (2002) Steal This Album!/03 - Bubbles.mp3" 2>&1
Removing track 3 (vorbis) from the queue..
Removing track 3 (mp3) from the queue..
Minutes ripping is 1.4305644076.
cdparanoia -Z [.31072]-[.10117] -d /dev/cdrom -O 0 
"/mnt/data/audio/new/flac/temp_sr0/track4_2.wav" 2>&1
Adding track 4 (flac) to the queue..
Adding track 4 (vorbis) to the queue..
Adding track 4 (mp3) to the queue..
command = oggenc -o "/mnt/data/audio/new/vorbis/System Of A Down (2002) Steal 
This 
Album!/04 - Boom!.ogg" -q 4 -c ALBUM="Steal This Album!" -c DATE="2002" -c 
GENRE="Metal" -c DISCID="de0a3310" -c ARTIST="System Of A Down" -c 
TITLE="Boom!" -c 
TRACKNUMBER=4 -c TRACKTOTAL=16 "/mnt/data/audio/new/flac/temp_sr0/track4_1.wav" 
2>&1
command = flac --best -V -o "/mnt/data/audio/new/flac/System Of A Down (2002) 
Steal 
This Album!/04 - Boom!.flac" --tag ALBUM="Steal This Album!" --tag DATE="2002" 
--tag 
GENRE="Metal" --tag DISCID="de0a3310" --tag ARTIST="System Of A Down" --tag 
TITLE="Boom!" --tag TRACKNUMBER=4 --tag TRACKTOTAL=16 
"/mnt/data/audio/new/flac/temp_sr0/track4_1.wav" 2>&1
Removing track 4 (flac) from the queue..
Ripping track 5
Expected filesize for track 5       is 26523548 bytes.
command = lame -V 3 --id3v2-only --tl "Steal This Album!" --ty "2002" --tg 
"Metal" --
tv TXXX=DISCID="de0a3310" --ta "System Of A Down" --tt "Boom!" --tn 4/16 
"/mnt/data/audio/new/flac/temp_sr0/track4_1.wav" 
"/mnt/data/audio/new/mp3/System Of A 
Down (2002) Steal This Album!/04 - Boom!.mp3" 2>&1
Free disk space is 556423880 MB
Minutes ripping is 1.7320098507.
cdparanoia -Z [.41190]-[.11276] -d /dev/cdrom -O 0 
"/mnt/data/audio/new/flac/temp_sr0/track5_1.wav" 2>&1
Removing track 4 (vorbis) from the queue..
Removing track 4 (mp3) from the queue..

Original comment by boukewou...@gmail.com on 1 Jun 2010 at 8:23

GoogleCodeExporter commented 8 years ago
What ruby version are you using?

I have the same issue with:
ruby-svn 26652-2 (which worked with that UTF gettext problem)
ruby-1.9.1_p378

Original comment by goo...@JonnyJD.net on 4 Jun 2010 at 7:34

GoogleCodeExporter commented 8 years ago
LOL

ruby has that weird "unless" statement. It might seem practical sometimes, but 
these
commits show one should be careful about using it:
http://github.com/rubyripperdev/rubyripper/commit/aa556907fe898b23e0ba34e4695dac
af7cc6613c
http://github.com/rubyripperdev/rubyripper/commit/ac30a1c90739cb17c0e51a873b0cf1
9f15c3e140

Basically:
You don't seem to have "verbose mode" enabled in rubyripper. Whoever has this 
enabled
will not be able to encode anything because the command is always empty.

I still have to test if at the current stage (with force_encoding) it is already
possible to redo this with command+= (without reopening issue 428) or if it has 
to be
done differently.

Original comment by goo...@JonnyJD.net on 4 Jun 2010 at 8:01

GoogleCodeExporter commented 8 years ago
Okay, fixing this issue with using command += breaks issue 428 again.

Well, maybe issue 428 was never fixed, but hidden by issue 429. This is also a
possibility.

Original comment by goo...@JonnyJD.net on 4 Jun 2010 at 8:12

GoogleCodeExporter commented 8 years ago
This issue is fixed for me with
http://github.com/JonnyJD/rubyripper/commit/32bab23f99c14640ecda212e05110e8605e3
eefb

basically (partly) reverting the mentioned commits.

Original comment by goo...@JonnyJD.net on 4 Jun 2010 at 9:16

GoogleCodeExporter commented 8 years ago
Thanks for finding the reason why it fails. I've solved it differently though:
http://github.com/rubyripperdev/rubyripper/commit/34b733cc0c47f250c9dd564e4fea10
2c403c
b5c8

I guess this fixes it for you as well, right?

Original comment by boukewou...@gmail.com on 4 Jun 2010 at 9:41

GoogleCodeExporter commented 8 years ago
Yep, the only difference are very long lines in your edit.

Original comment by goo...@JonnyJD.net on 4 Jun 2010 at 9:56

GoogleCodeExporter commented 8 years ago

Original comment by boukewou...@gmail.com on 5 Jun 2010 at 8:53