rlishtaba / rubyripper

Automatically exported from code.google.com/p/rubyripper
0 stars 0 forks source link

Problems ripping the last track. Some sectors are missing for track 20 : 2352 sector(s) #431

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago
1) Please describe the steps to reproduce the situation:
a. Rip this special disc.

2) What is the expected output? What do you see instead?
The last track should also be extracted.

3) What version of rubyripper are you using? On what operating system? The
gtk2 of commandline interface?
Git HEAD 8cf13ffee59ffb828abfbacf0e70d52d97a86597, Debian GNU/Linux, gtk2 
interface.

5) Does the problem happen with all discs?

RR worked with other discs.

If not, please attach the output of cdparanoia -Q with a disc that gives 
trouble.

$ cdparanoia -Q
cdparanoia III release 10.2 (September 11, 2008)

Table of contents (audio tracks only):
track        length               begin        copy pre ch
===========================================================
  1.    15639 [03:28.39]        0 [00:00.00]    no   no  2
  2.    25899 [05:45.24]    15639 [03:28.39]    no   no  2
  3.    10849 [02:24.49]    41538 [09:13.63]    no   no  2
  4.    14220 [03:09.45]    52387 [11:38.37]    no   no  2
  5.    14542 [03:13.67]    66607 [14:48.07]    no   no  2
  6.    15697 [03:29.22]    81149 [18:01.74]    no   no  2
  7.    14820 [03:17.45]    96846 [21:31.21]    no   no  2
  8.    19205 [04:16.05]   111666 [24:48.66]    no   no  2
  9.    13342 [02:57.67]   130871 [29:04.71]    no   no  2
 10.    18190 [04:02.40]   144213 [32:02.63]    no   no  2
 11.    15097 [03:21.22]   162403 [36:05.28]    no   no  2
 12.    13388 [02:58.38]   177500 [39:26.50]    no   no  2
 13.    12881 [02:51.56]   190888 [42:25.13]    no   no  2
 14.    14527 [03:13.52]   203769 [45:16.69]    no   no  2
 15.    13139 [02:55.14]   218296 [48:30.46]    no   no  2
 16.    11404 [02:32.04]   231435 [51:25.60]    no   no  2
 17.    17587 [03:54.37]   242839 [53:57.64]    no   no  2
 18.    16128 [03:35.03]   260426 [57:52.26]    no   no  2
 19.    12236 [02:43.11]   276554 [61:27.29]    no   no  2
 20.    15774 [03:30.24]   288790 [64:10.40]    no   no  2
TOTAL  304564 [67:40.64]    (audio only)

[…]

Please provide any additional information below. The more usefull
information provided, the sooner the issue will be fixed.

I do not know if this related to issue 310. But it was supposed to be fixed.

This is from the console output.

[…]
cdparanoia [.288790]- -d /dev/sr0 -O -472 "/flac/temp_sr0/track20_1.wav" 2>&1
Some sectors are missing for track 20 : 2352 sector(s)
Filesize should be : 37100492
Expected filesize for track 20      is 37100492 bytes.
Free disk space is 3157708 MB
Minutes ripping is 0.29382325.

Strangely running the cdparanoia command manually works.

$ cdparanoia [.288790]- -d /dev/sr0 -O -472 "track20_1.wav" 2>&1
cdparanoia III release 10.2 (September 11, 2008)

Ripping from sector  288790 (track 20 [0:00.01])
      to sector  304562 (track 20 [3:30.23])

outputting to track20_1.wav

 (== PROGRESS == [                              | 304562 00 ] == :^D * ==)   

Done.

Original issue reported on code.google.com by pm.deb...@googlemail.com on 26 Jun 2010 at 5:39

GoogleCodeExporter commented 8 years ago
Are you sure your offset is correct?  Even when running the cdparanoia command 
it does not go to the end of the disc (stops at 304562 instead of 304564).  Is 
there anything unique about this disc?  Copy protection or non-standard in any 
other way?

Original comment by mordbr...@gmail.com on 27 Jun 2010 at 8:08

GoogleCodeExporter commented 8 years ago
I guess I found the problem. It was comparing for offsets > 0. This was 
neglecting negative offsets. It should be fixed with:
http://github.com/rubyripperdev/rubyripper/commit/cebda4ad530a2876140da66e60b024
26a4c59636

Original comment by boukewou...@gmail.com on 24 Jul 2010 at 12:36

GoogleCodeExporter commented 8 years ago
@mordbrann: Sorry, I did not answer. I did not get information that you 
replied. :( Anyway, I checked the offset and it is correct. Great observation 
about the missing 2 sectors. cdparanoia reported »Some sectors are missing for 
track 20 : 2352 sector(s)« which is strange for me. But I do not know anything 
about this.

@boukewoudstra: I ran RR on the last track again with current master and it 
worked. Congratulations to spot such an error! So closing this bug yesterday 
and marking it as fixed was the right thing to do.

Original comment by pm.deb...@googlemail.com on 25 Jul 2010 at 4:05

GoogleCodeExporter commented 8 years ago
I´m glad it worked :) Thanks for the feedback!

Original comment by boukewou...@gmail.com on 25 Jul 2010 at 8:08