Poor warnings for uninstalled mp3gain and vorbisgain

[GoogleCodeExporter]

1) Please describe the steps to reproduce the situation:
a. Don't install one of mp3gain, vorbisgain or metaflac
b. In the gtk2 gui enable replaygain
c. Don't look at the console since it's a gui application.

2) What is the expected output? What do you see instead?
Ideally a warning would occur before the rip was started (during configuration) 
or as the rip was being started. The user would be able to choose the ignore it 
if they so wished. Instead I only noticed at the last possible moment.

3) What version of rubyripper are you using? On what operating system? The
gtk2 of commandline interface?

gtk2
$ rrip_cli --version
Rubyripper version 0.6.0.

4) Is this not already fixed with the latest & greatest code? See for
instructions the Source tab above.

Doesn't look like it.

5) Does the problem happen with all discs? If not, please attach
the output of cdparanoia -Q with a disc that gives trouble.

Yes

6) Please explain why this change is important for you. Also, how many
users would benefit from this change?

It's a general usability thing. Someone could easily mean to rip with 
replaygain but then not notice for ages.

Please provide any additional information below. The more usefull
information provided, the sooner the issue will be fixed.

Original issue reported on code.google.com by Frankie....@gmail.com on 27 Jun 2010 at 1:29

[GoogleCodeExporter]

I do consider this either a package maintainer issue or a user error. But 
anyway, you have a valid point that if I do show it in the terminal, I might as 
well make it generic. I've added a WARNING message in the logfile (which is 
shown while ripping) and cleaned up the messy code a bit while at it.

See commit:
http://github.com/rubyripperdev/rubyripper/commit/e47bfdbe21320c30a43d28ac130714
d0b2a68474

Original comment by boukewou...@gmail.com on 24 Jul 2010 at 10:30

• Changed state: Fixed