rlishtaba / rubyripper

Automatically exported from code.google.com/p/rubyripper
0 stars 0 forks source link

"album artist" tag should be "albumartist" #458

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago
1) Please describe the steps to reproduce the situation:
a.rip a disc
b.examine the tags with a tagger like Ex Falso

2) What is the expected output? What do you see instead?
It's particularly obvious if the tracks are also tagged via MusicBrainz Picard: 
there will be an "album artist" tag created by rubyripper and an "albumartist" 
tag created by Picard.

3) What version of rubyripper are you using? On what operating system? The
gtk2 of commandline interface?
rubyripper 0.6.0; Ubuntu 10.10 (Maverick); rrip_cli (because GTK2 takes too 
long)

4) Is this not already fixed with the latest & greatest code? See for
instructions the Source tab above.
Haven't tested with latest snapshot.

5) Does the problem happen with all discs? If not, please attach
the output of cdparanoia -Q with a disc that gives trouble.
All discs

6) Please explain why this change is important for you. Also, how many
users would benefit from this change?
Tag names with spaces aren't recognized by most of the other programs I use. I 
suspect it violates a standard, but I haven't verified this.

Please provide any additional information below. The more usefull
information provided, the sooner the issue will be fixed.

I've attached a patch that addresses the issue on my system.

Original issue reported on code.google.com by ld.bart...@gmail.com on 4 Apr 2011 at 6:04

Attachments:

GoogleCodeExporter commented 8 years ago
I don't consider this a bug since it's conform the standard, see for example:
http://wiki.hydrogenaudio.org/index.php?title=Foobar2000:Encouraged_Tag_Standard
s

Please file a bug for Picard instead.

Original comment by boukewou...@gmail.com on 22 Mar 2012 at 8:54

GoogleCodeExporter commented 8 years ago
I don't intend to file a Picard bug, as that tag is recognized by the other 
programs I've used.

The problem with the Foobar2000 standard is that it is not a format standard. 
As far as I can tell, Xiph.Org has not published a standard vorbis comment tag 
for album artist. This leaves the implementation open to interpretation.

While I respect your "WontFix" decision in this matter, you may wish to 
reconsider this issue if Xiph.Org publishes a recommendation or if the 
MusicBrainz usage becomes a de facto standard.

At least this explanation (and my patch) are available for others whose 
preferred players respect "albumartist" but not "album artist".

Thanks.

Original comment by ld.bart...@gmail.com on 23 Mar 2012 at 1:46