search

rlishtaba / rubyripper

Automatically exported from code.google.com/p/rubyripper
0 stars 0 forks source link

Add Lead-in/Lead-out padding setting to GTK Preferences #498

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago 
With the fix to Issue 490, an additional CLI preference "Pad missing 
lead-in/lead-out samples with zeroes" (Preferences::Main.padMissingSamples) was 
added, but this was not added to GTK.  I'm passing this to you Bouke, as you've 
recently been working on the GTK preferences in any case.

Original issue reported on code.google.com by comradec...@gmail.com on 14 Nov 2011 at 10:57

GoogleCodeExporter commented 8 years ago 
I plan to update the user interface for the new options indeed. First focus on 
getting it to work, just the way it was ;)

Original comment by boukewou...@gmail.com on 14 Nov 2011 at 11:04

GoogleCodeExporter commented 8 years ago 
This is fixed with commit:
http://code.google.com/p/rubyripper/source/detail?r=41f6b664ac5520bb07cf60f8ceb0
62c440c4b169

I keep this open as a reminder to add support for all the other new options ;)

Original comment by boukewou...@gmail.com on 19 Nov 2011 at 10:04

GoogleCodeExporter commented 8 years ago 
I just checked the musicbrainz options in. Can you please verify it's done 
correctly? (I am still not all that familiar with the musicbrainz options and 
am looking to add some help texts when hovering. Suggestions are welcome!)

Original comment by boukewou...@gmail.com on 19 Nov 2011 at 11:16

GoogleCodeExporter commented 8 years ago 
@Ian: What is the meaning of the 'no' option for the preferMusicBrainzDate 
setting? I don't do anything with it currently in the gtk2 user interface.

I do think the gtk2 gui is offering the same options as the cli currently with 
regards to the preference window. Therefore I am closing this issue.

Comments are welcome :)

Original comment by boukewou...@gmail.com on 23 Nov 2011 at 9:51