search

rlivings39 / vscode-fzf-quick-open

vscode extension providing quick file/folder open and searching using fzf
MIT License
77 stars 17 forks source link

Windows Cmd Escape Path issues with new terminal profiles #35

Open Inch4Tk opened 2 years ago

Inch4Tk commented 2 years ago

Same error as in issue #23, now caused by using terminal profiles instead of the deprecated terminal.integrated.shell config. The fix is straightforward, if the old term shell value is not set just query for the new default profile and check for cmd.exe there.

I will add a pull request.

rlivings39 commented 2 years ago

Closing based on merged PR. Please reopen if this is still an issue.

madjestic commented 1 year ago

Hey guys, I am experiencing the same issue on Windows 10.

Editing extension.js and making escapeWinPath return origPath seems to be fixing the issue. (as mentioned in https://github.com/rlivings39/vscode-fzf-quick-open/issues/23 )

NguyenHoangHieu22GIT2 commented 9 months ago

Hey guys, I am experiencing the same issue on Windows 10.

Editing extension.js and making escapeWinPath return origPath seems to be fixing the issue. (as mentioned in #23 )

Please provide more details please. Where is the file extension.js file ? I can not find it though.

rlivings39 commented 9 months ago

Hey guys, I am experiencing the same issue on Windows 10. Editing extension.js and making escapeWinPath return origPath seems to be fixing the issue. (as mentioned in #23 )

Please provide more details please. Where is the file extension.js file ? I can not find it though.

It's in the folder where extensions are installed:

https://code.visualstudio.com/docs/editor/extension-marketplace

On Windows, have a look in %USERPROFILE%\.vscode\extensions\rlivings39.fzf-quick-open-0.5.1\out\extension.js

Would you mind sharing the terminal settings from your settings.json? I'm guessing something is still messed up with that.

rlivings39 commented 9 months ago

Marking this as help wanted since I don't have access to any Windows machines right now. Any Windows-based contributor would be appreciated!