Implement file content search

rlivings39 / vscode-fzf-quick-open

vscode extension providing quick file/folder open and searching using fzf

MIT License

77 stars 17 forks source link

Implement file content search #6

Closed BuZZ-dEE closed 4 years ago

BuZZ-dEE commented 4 years ago

Hi, thx for this great plugin, I really like it.

Could you please also implement file content search?

rlivings39 commented 4 years ago

Seems doable. A few questions come to mind:

What would this do that the VSCode integrated search would do?
Do you have an fzf-based command in mind for doing the searching? What would the action be when you choose a search result? (open the associated file at the location?) I'm curious what you'd imagine the workflow to be

BuZZ-dEE commented 4 years ago

What would this do that the VSCode integrated search would do?

What do you mean? In My case I need this as a workaround for this bug. But I think it is good to have alternatives. ;)

Do you have an fzf-based command in mind for doing the searching?

Yes

What would the action be when you choose a search result? (open the associated file at the location?)

Just open the file in VSCode.

rlivings39 commented 4 years ago

Thanks for the feedback. Any specific fzf command you'd want to run? Or should I try to cook something up? My bias would be to try and use ripgrep with fzf

BuZZ-dEE commented 4 years ago

Yes, try to cook something using ripgrep. I already tried it and failed. ;)