Should be able to exit PHD2 when looping or guiding

[GoogleCodeExporter]

The exit button has no effect if PHD2 is looping or guiding. The user is 
required to press Stop before they can exit the app. It the user want to exit, 
we should let them!

Original issue reported on code.google.com by andy.gal...@gmail.com on 29 May 2013 at 10:54

[GoogleCodeExporter]

I thought of it when I began to work on PHD but did not dare commit it. There 
is only a "return;" to delete in MyFrame::OnClose, on the 3rd line. There is 
already all the function call to stop capturing and make all the disconnection 
to exit cleanly.

I thought there might be some specific hardware issue that explain this 
"return;". Maybe not...

Original comment by zesl...@gmail.com on 30 May 2013 at 6:54

[GoogleCodeExporter]

I really do not see any reason from a hardware perspective to dis-allow it. The 
code without the return is equivalent to the user pressing Stop then hitting 
Exit.

So I think it was a policy decision by whoever coded it that way to veto the 
event and prevent the exit unless the user hit Stop first.

Maybe somebody who knows the history could explain the rationale.

In my opinion, if the user hits exit, the app should exit!

Original comment by andy.gal...@gmail.com on 30 May 2013 at 7:05

[GoogleCodeExporter]

I propose we bring up a dialog box when the user clicks exit with exposures 
still running. The dialog box will say something like "Are you sure you want to 
exit?" and have a checkbox "Do not ask again". If the user checks the checkbox, 
we won't ask them again next time.

Original comment by andy.gal...@gmail.com on 2 Jun 2013 at 5:28

[GoogleCodeExporter]

Original comment by andy.gal...@gmail.com on 4 Jun 2013 at 5:12

• Changed state: Fixed

[GoogleCodeExporter]

fixed in r354

Original comment by andy.gal...@gmail.com on 4 Jun 2013 at 5:14