rljohn / kuinameplates-target-helper

MIT License
2 stars 5 forks source link

Color pickers do not show up in various options #30

Closed corcaroli closed 8 months ago

corcaroli commented 8 months ago

Hello, it seems that it's not possible to pick colors in any addon option section after the 10.2.5 update (addon version 1.4.5). When I try doing it by clicking on the color indicator squire, color picker simply does not show up. (and nothing happens at all)

This is what appears in the BugSack when i try doing it in the "Debuff Colors" section, for instance:

1x Kui_Nameplates_TargetHelper/helper.lua:371: attempt to call method 'SetColorRGB' (a nil value)
[string "@Kui_Nameplates_TargetHelper/helper.lua"]:371: in function `ShowColorPicker'
[string "@Kui_Nameplates_TargetHelper/helper.lua"]:508: in function `AuraColorOnClick'
[string "@Kui_Nameplates_TargetHelper/auras_panel.lua"]:65: in function <...eKui_Nameplates_TargetHelper/auras_panel.lua:64>

Locals:
self = KuiConfigTargetHelper {
 0 = <userdata>
 AddTooltip = <function> defined @Kui_Nameplates_TargetHelper/helper.lua:147
 ShouldResetFrames = false
 CreateCheckBox = <function> defined @Kui_Nameplates_TargetHelper/helper.lua:179
 Initialized = true
 class = <table> {
 }
 TargetEdit = <function> defined @Kui_Nameplates_TargetHelper/targets_panel.lua:240
 currentEditName = ""
 original_kui_show_function = <function> defined @Kui_Nameplates/addon.lua:93
 SetClassAuraChecked = <function> defined @Kui_Nameplates_TargetHelper/helper.lua:255
 EnsureSpecEnabledValid = <function> defined @Kui_Nameplates_TargetHelper/helper.lua:199
 ResetFrames = <function> defined @Kui_Nameplates_TargetHelper/helper.lua:87
 CreateButton = <function> defined @Kui_Nameplates_TargetHelper/helper.lua:565
 CustomInterruptsOnClick = <function> defined @Kui_Nameplates_TargetHelper/helper.lua:454
 CreateColorTexture = <function> defined @Kui_Nameplates_TargetHelper/helper.lua:513
 CreatePanel = <function> defined @Kui_Nameplates_TargetHelper/helper.lua:586
 ConfirmDelete = <function> defined @Kui_Nameplates_TargetHelper/config.lua:408
 CreateSliderWithReload = <function> defined @Kui_Nameplates_TargetHelper/helper.lua:844
 plugin_execute = <table> {
 }
 ui = <table> {
 }
 NeedsSpellListConfig = <function> defined @Kui_Nameplates_TargetHelper/helper.lua:215
 IsDragonFlight = true
 CancelGlobal = <function> defined @Kui_Nameplates_TargetHelper/config.lua:402
 CustomTargetColorOnClick = <function> defined @Kui_Nameplates_TargetHelper/helper.lua:446
 OnExecutePluginEnabled = <function> defined @Kui_Nameplates_TargetHelper/panels.lua:198
 name = "Kui |cff9966ffTarget Helper"
 ConfirmFilterDelete = <function> defined @Kui_Nameplates_TargetHelper/filter_panel.lua:144
 AuraColorOnClick = <function> defined @Kui_Nameplates_TargetHelper/helper.lua:497
 EvaluateFilter = <function> defined @Kui_Nameplates_TargetHelper/helper.lua:60
 ConfirmGlobalLoad = <function> defined @Kui_Nameplates_TargetHelper/config.lua:383
 AddToSpellList = <function> defined @Kui_Nameplates_TargetHelper/helper.lua:226
 original_kui_hide_function = <function> defined @Kui_Nameplates/addon.lua:117
 ShouldFilterUnit = <function> defined @Kui_Nameplates_TargetHelper/helper.lua:47
 ConfirmTargetDelete = <function> defined @Kui_Nameplates_TargetHelper/targets_panel.lua:341
 currentInterruptId = ""
 ShowColorPicker = <function> defined @Kui_Nameplates_TargetHelper/helper.lua:369
 global = <table> {
 }
 Update = <function> defined @Kui_Nameplates_TargetHelper/config.lua:283
 PendingInterrupts = false
 ConfirmInterruptDelete = <function> defined @Kui_Nameplates_TargetHelper/interrupts_panel.lua:324
 CreateIcon = <function> defined @Kui_Nameplates_TargetHelper/helper.lua:871
 CreateSlider = <function> defined @Kui_Nameplates_TargetHelper/helper.lua:306
 UpdateInterval = 1
 AddTooltip2 = <function> defined @Kui_Nameplates_TargetHelper/helper.lua:129
 SetupLocale = <function> defined @Kui_Nameplates_TargetHelper/localisation.lua:3
 info = <table> {
 }
 env = <table> {
 }
 TimeSinceLastUpdate = 0.731000
 ReloadGlobalData = <function> defined @Kui_Nameplates_TargetHelper/config.lua:369
 OnTooltipLeave = <function> defined @Kui_Nameplates_TargetHelper/helper.lua:121
 CreateClassAuraCheckBox = <function> defined @Kui_Nameplates_TargetHelper/helper.lua:279
 ColorPickerOnClick = <function> defined @Kui_Nameplates_TargetHelper/helper.lua:378
 ConfirmRenameDelete = <function> defined @Kui_

It also seems that a similar issue with the SetColorRGB method appeared in ElvUI after the update.

rljohn commented 8 months ago

Thanks, taking a look.

rljohn commented 8 months ago

https://github.com/rljohn/kuinameplates-target-helper/commit/48970a2e20e9ed2d0d3f0820275500c127f7426b