rljohn / pibuddy

World of Warcraft Addon for optimizing Power Infusion usage
0 stars 0 forks source link

Feature Request: Additional macro options. #2

Open gotex007 opened 1 year ago

gotex007 commented 1 year ago

Is it possible to have some additional macro options like the nochanneling conditional and having the option to remove the @player part?

rljohn commented 1 year ago

The macro is pushing against the 255 macro character limit for cross realm names, so adding nochanneling conditionals to each cast line wouldn't fit unless we find a way to shorten/remove other lines.

gotex007 commented 1 year ago

Yeah I did notice that. I'd personally be unticking some of the options (like the @player line) to make room for the nochanneling conditional. I tried doing it myself but the addon just overwrites any changes to the macro made manually when I select a buddy since it has to generate the macro again.

gotex007 commented 1 year ago

There are also some small things that can be done to reduce macro character count. /use can be used instead of /cast (very minor). The server name also isn't required to cast the spell on them and I'd imagine it's very unlikely you would ever be in a group with two people of literally the exact name. Another thing that I don't think would run into issues unless the target is mind-controlled is being able to take out the "help" conditional in the casting at your pibuddy line and the /stopmacro line since they should always be an ally when you're trying to cast it. These three things would save like 25-49 characters, depending on the length of the server name.

gotex007 commented 1 year ago

Can also use harm instead of nohelp to save 2 characters.