search

rlmead / gather-here

https://gather-here.net
GNU General Public License v3.0
2 stars 0 forks source link

Add maintenance page #30

Closed aberonni closed 7 months ago

aberonni commented 7 months ago

Closes #29

vercel[bot] commented 7 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
gather-here ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 24, 2024 5:38pm
aberonni commented 7 months ago

You should be able to test this by visiting the Vercel preview for this PR and then toggling the edge config in the Vercel dashboard. The website should switch between states. Let me know what you think!

rlmead commented 7 months ago

You should be able to test this by visiting the Vercel preview for this PR and then toggling the edge config in the Vercel dashboard. The website should switch between states. Let me know what you think!

@aberonni It works perfectly!! Just one minor comment to address before merging, but everything else looks great to me 😄 Thank you!

rlmead commented 7 months ago

@aberonni FYI these are the merging conventions that I follow:

Let me know if you know of any reason to do things differently! I realize there's only one commit here but I'm gonna go ahead and squash merge out of habit and superstition 😆

aberonni commented 7 months ago

@aberonni FYI these are the merging conventions that I follow:

  • squash merge into dev
  • merge commit into main

Let me know if you know of any reason to do things differently! I realize there's only one commit here but I'm gonna go ahead and squash merge out of habit and superstition 😆

I've pretty much always just done a simple merge, but with an enforcement on branches to be rebased before merging. I don't know the specifics of why I've ended up doing that - it's something a wiser programmer than me passed on to me eons ago :D

I have no opinion or preference so your flow sounds good to me ✌️