search

rlogiacco / BatterySense

Arduino library to monitor battery consumption
GNU Lesser General Public License v3.0
416 stars 76 forks source link

higher-on-demand circuit #3

Closed mesmerise closed 8 years ago

mesmerise commented 8 years ago

Hi there,

big up & thx for the library, it works very well!

There seems to be a minor issue with the suggested circuit for the higher-on-demand scenario. Correct me if I am wrong, but I believe the n-channel MOSFET in circuit diagram is connected wrongly: Source should be connected to GND and drain should be connected to R2 and not vice versa as shown in higher-on-demand.png.

Best, Andreas

rlogiacco commented 8 years ago

Hi Andreas, good catch, you are definitely right! Would you like to submit a pull request with an updated circuit diagram for that?

mesmerise commented 8 years ago

Thanks mate, I’m fairly new to Github - I tried to create a pull request with an updated diagram - hope it worked..

On 16 Jun 2016, at 13:52, Roberto Lo Giacco notifications@github.com wrote:

Hi Andreas, good catch, you are definitely right! Would you like to submit a pull request with an updated circuit diagram for that?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/rlogiacco/BatterySense/issues/3#issuecomment-226463556, or mute the thread https://github.com/notifications/unsubscribe/AQ7PbsssUmjdyflCj7IMwtgAI2-QpY2Rks5qMTkbgaJpZM4I3K2-.

rlogiacco commented 8 years ago

It did work indeed... Can you remove the additional V3 part at the end of the file name?

mesmerise commented 8 years ago

I couldn’t change the filename directly, but I uploaded a renamed version just a few minutes ago.

On 16 Jun 2016, at 15:07, Roberto Lo Giacco notifications@github.com wrote:

It did work indeed... Can you remove the additional V3 part at the end of the file name?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/rlogiacco/BatterySense/issues/3#issuecomment-226479359, or mute the thread https://github.com/notifications/unsubscribe/AQ7Pbnabkw2guh1pAO2TRe92CU4PAUHIks5qMUp2gaJpZM4I3K2-.

rlogiacco commented 8 years ago

pull request accepted: thank you!