search

rlouf / mcx

Express & compile probabilistic programs for performant inference on CPU & GPU. Powered by JAX.
https://rlouf.github.io/mcx
Apache License 2.0
325 stars 17 forks source link

Add HalfNormal distribution #100

Closed shwinnn closed 3 years ago

shwinnn commented 3 years ago

Adds the HalfNormal distribution. I force it to be bounded below at 0 to match the APIs of other PPL libraries (e.g. numpyro, tensorflow probability

rlouf commented 3 years ago

I would really like to merge this before the first release. Is there anything I can do to help?

shwinnn commented 3 years ago

Hi, sorry I just haven't found the time to write the tests. If I have the downtime I will have a look but I don't have a specific timeframe for you I'm afraid!

rlouf commented 3 years ago

No problem, take your time!

rlouf commented 3 years ago

It looks good to me, merging. Thank you for taking the time to add the HalfNormal distribution to MCX!

rlouf commented 3 years ago

Actually, would you mind squashing all your commits? Github doesn't suggest you as a co-author if I squash the commits myself here, and I wouldn't want you to not appear as a contributor.

rlouf commented 3 years ago

Merging, thanks again!