search

rlouf / mcx

Express & compile probabilistic programs for performant inference on CPU & GPU. Powered by JAX.
https://rlouf.github.io/mcx
Apache License 2.0
325 stars 17 forks source link

Replaced: np to jnp; onp to np #73

Closed kancurochat closed 3 years ago

kancurochat commented 3 years ago

Replaced all np references to jnp and onp to np.

rlouf commented 3 years ago

That was fast! The CI breaks because it looks like black would have reformatted a few files. You can install the dev requirements with pip install -r requirements-dev.txt and then run black mcx tests.

The CI performs the same checks as when you do make lint with the following GNUMakefile: https://github.com/rlouf/mcx/blob/master/Makefile

kancurochat commented 3 years ago

Alright! As soon as I get home, I'll check it with black!

balancap commented 3 years ago

Thanks! I wanted to ask about this naming update too :)

rlouf commented 3 years ago

That looks great! Could you squash your commits before I merge?

@balancap That's the convention the JAX team is using now. See why here: https://github.com/google/jax/issues/4643

rlouf commented 3 years ago

Merged! Thanks for taking the time to replace all these before it becomes unmanageable 😅