search

rlr / dotjs-addon

[unmaintained] ~/.js for Firefox
BSD 3-Clause "New" or "Revised" License
144 stars 17 forks source link

Hangs & Slow Script Warnings #16

Open zpao opened 12 years ago

zpao commented 12 years ago

I noticed lots of mini pauses with Nightly recently and started getting slow script warnings from dotjs. I've disabled and things seem to be better. Today, I only noticed the problem several hours after my last restart, so it could be that it's just leaking or has it's hand in too many tabs...

Since it's a recent development, I'm leaning towards the change from using PageMods, but I don't know the Addon SDK well enough to say that for sure.

Also of note: I have a lot of tabs (142 at the moment, often more, but most aren't loaded), so I may be above the normal threshold.

Sorry I don't have any hard evidence, but it's something to keep an eye out for!

rlr commented 12 years ago

Thanks for the report! Looking at the code now that it is based on tabs, I am pretty sure I can refactor it so that it only "attaches" to the tab (injecting jquery, etc) if there is a script to load for the domain. I am thinking this should be a pretty big improvement.

rlr commented 12 years ago

@zpao There is a new version up on AMO that I hope helps this issue. If you can try it out with your 142 problems, let me know what happens :-). Thanks.

zpao commented 12 years ago

I'll re-enable it and see how it goes. Thanks for looking into it!