Leaner, meaner dotjs - Githubissues

rlr / dotjs-addon

[unmaintained] ~/.js for Firefox

BSD 3-Clause "New" or "Revised" License

144 stars 17 forks source link

Leaner, meaner dotjs #19

Closed jeffgca closed 12 years ago

jeffgca commented 12 years ago

I've done a bunch of work refactoring dotjs based on conversations with SDK devs around minimizing memory footprint. These changes feature a few different bits:

I switched back to using page-mod and instead bailing out on iframes very early in the content script.
I only load jquery into a page if there is a match
I separated out the actual matching of filenames to a different module, ideally one could write tests for it.

rlr commented 12 years ago

Sweet, I'll take a look and hopefully learn a trick or two :-). thanks!

rlr commented 12 years ago

Woot. I like. I still need to read up on when I should use things like let. As a webdev, I never get to use that :-/.

Squashed and landed: 4dc4f9f033142ae6f17a141d5a9cca7ae65a4d97

I'll use it for a few days and then submit it to AMO.