rlr / dotjs-addon

[unmaintained] ~/.js for Firefox
BSD 3-Clause "New" or "Revised" License
144 stars 17 forks source link

Scripts not run on private window #35

Closed LouCypher closed 8 years ago

LouCypher commented 10 years ago

STR: just open private window and load a site that has custom script.

mspreij commented 8 years ago

No fixes? :-/ I would like this as well, possibly optionally.

eridal commented 8 years ago

Seems like we need to add this link to package.json

"permissions": {"private-browsing": true}

https://developer.mozilla.org/en-US/Add-ons/SDK/High-Level_APIs/private-browsing#Opting_into_private_browsing

mspreij commented 8 years ago

:+1: Yes please :-) I'm not familiar with manually building extensions, but I'm patient..

(ps. https://jetpack.mozillalabs.com/sdk/latest/docs/ in the README doesn't work, http:// etc does.)

rlr commented 8 years ago

^^ Landed fix. It will go out in next version

rlr commented 8 years ago

The new version has already been approved and released: https://addons.mozilla.org/en-US/firefox/addon/dotjs/

:balloon:

mspreij commented 8 years ago

\o/ thanks!