search

rluiten / elm-date-extra

Elm Date Extra library add/subtract/diff/format etc dates
http://package.elm-lang.org/packages/rluiten/elm-date-extra/latest
BSD 3-Clause "New" or "Revised" License
75 stars 36 forks source link

Add locale for Brazilian Portuguese 🇧🇷 #26

Closed cuducos closed 7 years ago

cuducos commented 7 years ago

Hey you… as I got that new locales are welcomed, and as I just wrote the pt-BR locale to use this package in a project, I thought that the PR would be interesting…

Thanks for creating and maintaining elm-date-extra ; )

rluiten commented 7 years ago

Ahh its elm-format, I should have guessed that.

I usually like the case statement formatting of it when I played with it ages back, but for these specific files where the days in a week and months in a year just are not going to change, and where the result is a single string I find the vertical orientation annoying.

I thought elm-format was 2 space indent have the changed again ? I've been moving to 2 spaces because elm-format was doing that hmm a year ago I suppose now.

What about the the padding code in dayOfMonthWithSuffix is 4 really correct ?

rluiten commented 7 years ago

Hmm ok elm-format only does 4, I do remember some discussions on the slack channel and I came away thinking it was changing to 2, I was wrong. :).

rluiten commented 7 years ago

Published 8.2.0