search

rluiten / elm-date-extra

Elm Date Extra library add/subtract/diff/format etc dates
http://package.elm-lang.org/packages/rluiten/elm-date-extra/latest
BSD 3-Clause "New" or "Revised" License
75 stars 36 forks source link

Remove Debug.log from package before publishing #27

Closed cuducos closed 7 years ago

cuducos commented 7 years ago

It looks like there are two Debug.log that shouldn't be there (at least, not in production). Both in Date.Extra.Internal: lines 18-26 and 30.

rluiten commented 7 years ago

These updates should be in next release (in next few hours).

cuducos commented 7 years ago

Yay. Many thanks for that ; ) Count down to the ext release 🕐

rluiten commented 7 years ago

Hope this change doesn't cause pain for people. Oh well we shall see. As I can't force a Major version change as the API is the same just a constant config changed.

cuducos commented 7 years ago

Hope this change doesn't cause pain for people

Please, this is not a critique but IMHO a pain was to debug with my own Debug.log when elm-date-extra was polluting my console with a log of unrequested logs… I mean, saying it as a pain is a bit overreacting, but it was a bit annoying ; )

rluiten commented 7 years ago

Oops my comment about pain for others was not meant for Debug.log left overs. I got log mixed up with Format.isoString and Format.isoMsecOffsetFormat :) sorry.

Removing Debug.log's yes totally should not do it in production or maybe provide config to allow it, but definitly not just log, it was an oversite on my part.

cuducos commented 7 years ago

Hahaha… got it!