search

rluiten / elm-date-extra

Elm Date Extra library add/subtract/diff/format etc dates
http://package.elm-lang.org/packages/rluiten/elm-date-extra/latest
BSD 3-Clause "New" or "Revised" License
75 stars 36 forks source link

Add Russian locale #36

Closed tvv closed 7 years ago

tvv commented 7 years ago

Sorry for previous pull request, i was on hurry.

Hi, sorry I havnt had time to get to Elm just enough time to keep an eye on Pull Requests. Was planning to merge this weekend. @tvv

rluiten commented 7 years ago

Hi, sorry I havnt had time to get to Elm just enough time to keep an eye on Pull Requests. Was planning to merge this weekend. @tvv

tvv commented 7 years ago

I just merged german locale and made some changes for local usage. Tests passed succefully.

You should revert package info. Or wait for i'll do.

tvv commented 7 years ago

Correct candidate - https://github.com/relabsoss/elm-date-extra/tree/ru_de_locale

rluiten commented 7 years ago

I am really not sure how to create a pull request from your branch to mine, I tried but it has conflicts and I believe that makes merges on github not possible. I can drive github but I am no expert.

tvv commented 7 years ago

It should be done over console, but its not trivial)

rluiten commented 7 years ago

I understand the local process, and believe i did it right fixed the few merge conflicst., but now I don't have the ru_ru configs in branch. I am going to reset master back to when i merged the german translation and try again

tvv commented 7 years ago

You can merge https://github.com/relabsoss/elm-date-extra/tree/ru_de_locale branch which already has DE locale modules.

But german locale modules not exported...

rluiten commented 7 years ago

Ok the reset made it simple, published 8.4.0. Cheers!

tvv commented 7 years ago

Nice)