search

rlworkgroup / dowel

A little logger for machine learning research
MIT License
32 stars 37 forks source link

Rewrite automatic versioning #25

Closed ryanjulian closed 5 years ago

ryanjulian commented 5 years ago

The previous automatic versioning script was flawed. It produced the correct package version for documentation builds and building PyPI distributions, but produced an incorrect version when you run setup.py from the downloaded package. Unfortunately, Python environment managers (e.g. Pipenv, conda) resolve package version by evaluating setup.py, not using the PyPI version.

This PR makes version generation simpler by reading the version string from a simple file. Automatic versioning from tags is handled by clobbering the version file from within the CI, rather than looking for a CI environment variable on every usage.

codecov[bot] commented 5 years ago

Codecov Report

Merging #25 into master will increase coverage by 0.87%. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #25      +/-   ##
=========================================
+ Coverage   93.53%   94.4%   +0.87%     
=========================================
  Files           8       7       -1     
  Lines         325     322       -3     
  Branches       47      47              
=========================================
  Hits          304     304              
+ Misses         14      11       -3     
  Partials        7       7

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 8aa5c7a...2587c85. Read the comment docs.