search

rlworkgroup / dowel

A little logger for machine learning research
MIT License
32 stars 37 forks source link

Fix tests, add Tensorflow 2 compat #36

Closed krzentner closed 5 years ago

krzentner commented 5 years ago

Unfortunately, fixing the tests involves monkey patching unittest, since it has bug. That bug is fixed in CPython PR #4800, which has gone unmerged for over a year.

codecov[bot] commented 5 years ago

Codecov Report

Merging #36 into master will decrease coverage by 0.2%. The diff coverage is 77.77%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #36      +/-   ##
=========================================
- Coverage    94.4%   94.2%   -0.21%     
=========================================
  Files           7       7              
  Lines         322     328       +6     
  Branches       47      48       +1     
=========================================
+ Hits          304     309       +5     
- Misses         11      12       +1     
  Partials        7       7
Impacted Files Coverage Δ
src/dowel/tensor_board_output.py 96.61% <77.77%> (-1.51%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 7848974...559b5bd. Read the comment docs.

krzentner commented 5 years ago

The remaining diff lines can only be hit by running tests without Tensorflow installed, so I'm just going to push this.