rlworkgroup / dowel

A little logger for machine learning research
MIT License
32 stars 37 forks source link

Add Python 3.8 build #48

Closed irisliucy closed 4 years ago

irisliucy commented 4 years ago

The current issue #45 is caused by inconsistent keys in tabularInput with csvOutput headers. To fix this: 1) Read the existing log file 2) Update the csv Dictwriter with the new header using union

The cons of this solution:

A better approach can be:

rlworkgroup#45 @avnishn @zequnyu

codecov[bot] commented 4 years ago

Codecov Report

Merging #48 into master will decrease coverage by 0.83%. The diff coverage is 73.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #48      +/-   ##
==========================================
- Coverage   94.13%   93.29%   -0.84%     
==========================================
  Files           7        7              
  Lines         358      373      +15     
  Branches       58       60       +2     
==========================================
+ Hits          337      348      +11     
- Misses         12       16       +4     
  Partials        9        9              
Impacted Files Coverage Δ
src/dowel/csv_output.py 90.56% <73.33%> (-6.81%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update a8b5134...5351f6e. Read the comment docs.

avnishn commented 4 years ago

@irisliucy you need to open this pr onto your fork and then email us, as per the instructions.

irisliucy commented 4 years ago

@avnishn Sorry for the inconvenience. I've opened this pr to my fork repo instead. I appreciated your reminder.