Closed irisliucy closed 4 years ago
Merging #48 into master will decrease coverage by
0.83%
. The diff coverage is73.33%
.
@@ Coverage Diff @@
## master #48 +/- ##
==========================================
- Coverage 94.13% 93.29% -0.84%
==========================================
Files 7 7
Lines 358 373 +15
Branches 58 60 +2
==========================================
+ Hits 337 348 +11
- Misses 12 16 +4
Partials 9 9
Impacted Files | Coverage Δ | |
---|---|---|
src/dowel/csv_output.py | 90.56% <73.33%> (-6.81%) |
:arrow_down: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update a8b5134...5351f6e. Read the comment docs.
@irisliucy you need to open this pr onto your fork and then email us, as per the instructions.
@avnishn Sorry for the inconvenience. I've opened this pr to my fork repo instead. I appreciated your reminder.
The current issue #45 is caused by inconsistent keys in
tabularInput
withcsvOutput
headers. To fix this: 1) Read the existing log file 2) Update the csv Dictwriter with the new header using uniontabularInput
's andcsvOutput
's header is used to make sure all keys from both instances are captured 3) Write the same log file with new key headers and old data. If the value of new key is missing, the cell is left blank.The cons of this solution:
A better approach can be:
rlworkgroup#45 @avnishn @zequnyu