search

rlworkgroup / garage

A toolkit for reproducible reinforcement learning research.
MIT License
1.88k stars 310 forks source link

Allow setting total_env_steps #2124

Closed krzentner closed 4 years ago

krzentner commented 4 years ago

This is needed to allow the Trainer not to know about the Samplers directly See issue #2120

krzentner commented 4 years ago

@Mergifyio rebase

mergify[bot] commented 4 years ago

Command rebase: success

Branch has been successfully rebased

codecov[bot] commented 4 years ago

Codecov Report

Merging #2124 (da9edcc) into master (6c94508) will decrease coverage by 0.06%. The diff coverage is 50.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2124      +/-   ##
==========================================
- Coverage   91.58%   91.51%   -0.07%     
==========================================
  Files         197      197              
  Lines       10927    10929       +2     
  Branches     1387     1387              
==========================================
- Hits        10007    10002       -5     
- Misses        664      669       +5     
- Partials      256      258       +2
Impacted Files Coverage Δ
src/garage/trainer.py 90.94% <50.00%> (-0.32%) :arrow_down:
...rage/tf/optimizers/conjugate_gradient_optimizer.py 81.90% <0.00%> (-1.81%) :arrow_down:
src/garage/sampler/multiprocessing_sampler.py 89.61% <0.00%> (-1.30%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 6c94508...da9edcc. Read the comment docs.