search

rlworkgroup / garage

A toolkit for reproducible reinforcement learning research.
MIT License
1.86k stars 310 forks source link

Fix #2131 #2132

Closed avnishn closed 3 years ago

avnishn commented 3 years ago

There's something specifically wrong with an image used in rendering pendulum-v0, causing visualize to fail.

I swapped it out with CartPole-v1 for the purposes of the tests and that was a fix.

maliesa96 commented 3 years ago

I'm still curious as to why it would suddenly stop working with pendulum but I'm okay with this being the fix.

codecov[bot] commented 3 years ago

Codecov Report

Merging #2132 into master will increase coverage by 22.98%. The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           master    #2132       +/-   ##
===========================================
+ Coverage   70.17%   93.16%   +22.98%     
===========================================
  Files         194      194               
  Lines       10503    10503               
  Branches     1321     1321               
===========================================
+ Hits         7371     9785     +2414     
+ Misses       2785      473     -2312     
+ Partials      347      245      -102
Impacted Files Coverage Δ
src/garage/torch/algos/pearl.py 95.91% <0.00%> (+0.34%) :arrow_up:
src/garage/tf/_functions.py 78.20% <0.00%> (+0.64%) :arrow_up:
src/garage/tf/algos/rl2.py 95.71% <0.00%> (+0.71%) :arrow_up:
...rc/garage/tf/optimizers/penalty_lbfgs_optimizer.py 88.88% <0.00%> (+1.11%) :arrow_up:
...arage/torch/policies/context_conditioned_policy.py 91.01% <0.00%> (+1.12%) :arrow_up:
src/garage/torch/algos/sac.py 97.09% <0.00%> (+1.16%) :arrow_up:
src/garage/tf/algos/npo.py 96.46% <0.00%> (+1.32%) :arrow_up:
src/garage/sampler/fragment_worker.py 95.83% <0.00%> (+1.38%) :arrow_up:
src/garage/tf/algos/dqn.py 91.52% <0.00%> (+1.69%) :arrow_up:
src/garage/sampler/default_worker.py 100.00% <0.00%> (+2.50%) :arrow_up:
... and 97 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update b4b7aa1...690d5a3. Read the comment docs.