rlworkgroup / garage

A toolkit for reproducible reinforcement learning research.
MIT License
1.88k stars 310 forks source link

Unpin cloudpickle #2133

Closed gitanshu closed 4 years ago

gitanshu commented 4 years ago

closes #1882

tensorflow/probability 0.11.1 is out which allows compatibility with cloudpickle >= 1.3, so we don't need to pin it anymore

codecov[bot] commented 4 years ago

Codecov Report

Merging #2133 into master will decrease coverage by 0.02%. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2133      +/-   ##
==========================================
- Coverage   93.20%   93.17%   -0.03%     
==========================================
  Files         194      194              
  Lines       10519    10519              
  Branches     1321     1321              
==========================================
- Hits         9804     9801       -3     
- Misses        474      475       +1     
- Partials      241      243       +2     
Impacted Files Coverage Δ
...rage/tf/optimizers/conjugate_gradient_optimizer.py 81.90% <0.00%> (-1.81%) :arrow_down:
src/garage/experiment/deterministic.py 90.32% <0.00%> (+3.22%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 06e5aba...abdc64a. Read the comment docs.

gitanshu commented 4 years ago

Does this need to be backported?

I'd say it's good to backport. We managed to resolve the other conflicts but pinning cloudpickle still conflicts with dask.distributed > 2.20.0

gitanshu commented 4 years ago

@mergifyio rebase

mergify[bot] commented 4 years ago

Command rebase: success

Branch already up to date