search

rlworkgroup / garage

A toolkit for reproducible reinforcement learning research.
MIT License
1.86k stars 310 forks source link

Make mujoco test run a few minutes faster #2143

Closed krzentner closed 3 years ago

krzentner commented 3 years ago

This test suite has run out of time, and it's blocking merging algorithms. This should buy us about six more minutes of time to run new tests.

codecov[bot] commented 3 years ago

Codecov Report

Merging #2143 into master will decrease coverage by 1.45%. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2143      +/-   ##
==========================================
- Coverage   93.24%   91.79%   -1.46%     
==========================================
  Files         194      194              
  Lines       10526    10526              
  Branches     1321     1321              
==========================================
- Hits         9815     9662     -153     
- Misses        469      622     +153     
  Partials      242      242
Impacted Files Coverage Δ
src/garage/torch/algos/pearl.py 48.29% <0.00%> (-47.62%) :arrow_down:
src/garage/envs/metaworld_set_task_env.py 90.35% <0.00%> (-3.51%) :arrow_down:
...rage/tf/optimizers/conjugate_gradient_optimizer.py 81.90% <0.00%> (-1.81%) :arrow_down:
src/garage/np/_functions.py 84.42% <0.00%> (-1.64%) :arrow_down:
src/garage/sampler/multiprocessing_sampler.py 89.61% <0.00%> (-1.30%) :arrow_down:
src/garage/trainer.py 89.57% <0.00%> (-0.39%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 3a0f8d1...aed79ee. Read the comment docs.

ryanjulian commented 3 years ago

A simple solution here is to run these tests in GH Actions only, since it's only Travis which has the very short limit. We have seen good test stability from GH Actions so I think it's safe to do this for every test job except deployments @ziyiwu9494

krzentner commented 3 years ago

The only one I actually disabled here was the PEARL test. If someone can make it run faster or add a tag to make it run in GH Actions that would be great, but this is blocking other changes from being merged, so I'm going to merge it as-is.