rlworkgroup / garage

A toolkit for reproducible reinforcement learning research.
MIT License
1.86k stars 310 forks source link

Fix warning regarding ABC import from collections #2146

Closed tirkarthi closed 3 years ago

tirkarthi commented 3 years ago

Import from collections.abc instead of collections which has been deprecated and will be removed in future.

ryanjulian commented 3 years ago

@tirkarthi thank you for this PR! @haydenshively since you are tree sheriff this week, please shepherd this through the merge process. GH actions doesn't yet support PRs from outside rlworkgroup, so you will need me or @krzentner to force-push it when it's ready.

haydenshively commented 3 years ago

I'll run tests locally and let you know if/when everything passes

haydenshively commented 3 years ago

Everything passed except spec19 in test_all_gym_envs, which seems unrelated to this change

ryanjulian commented 3 years ago

@mergifyio rebase

mergify[bot] commented 3 years ago

Command rebase: success

Branch has been successfully rebased

ryanjulian commented 3 years ago

@mergifyio rebase

mergify[bot] commented 3 years ago

Command rebase: success

Branch has been successfully rebased

ryanjulian commented 3 years ago

@mergifyio rebase

mergify[bot] commented 3 years ago

Command rebase: success

Branch has been successfully rebased