Package registry login on Github fails

rlworkgroup / garage

A toolkit for reproducible reinforcement learning research.

MIT License

1.86k stars 310 forks source link

Package registry login on Github fails #2171

Open mugoh opened 3 years ago

mugoh commented 3 years ago

I have an open PR and the CI check is unable to build the docker container. It fails with: Screenshot from 2020-11-05 15-14-49

I haven't changed any setup files on the repository and I'm unable to resolve the issue. How should one resolve this?

Thanks

Update: From the error, it seems some github secrets are not passed to my fork. CODEDEV_TOKEN and MJKEY are blank

ryanjulian commented 3 years ago

@ziyiwu9494

krzentner commented 3 years ago

Yeah, unfortunately PR from people outside the rlworkgroup organization don't get access to MJKEY or CODEDEV_TOKEN. We're looking into a solution for this, but in the meantime we can merge and test external PRs manually.

The CI uses multiple jobs, but essentially what it does is equivalent to running pre-commit (instructions for which can be found in CONTRIBUTING.md, and pytest -m "not flaky and not nightly" tests (after starting an X server, since some tests require a display).