yeukfu commented 3 years ago

Pip release 20.3 today, which makes the CI build failed. Here is the log, and the related issue.

codecov[bot] commented 3 years ago

Codecov Report

Merging #2188 (9ca6a91) into master (f856f74) will decrease coverage by 0.19%. The diff coverage is 94.80%.

@@            Coverage Diff             @@
##           master    #2188      +/-   ##
==========================================
- Coverage   91.36%   91.17%   -0.20%     
==========================================
  Files         198      198              
  Lines       10944    10912      -32     
  Branches     1374     1367       -7     
==========================================
- Hits         9999     9949      -50     
- Misses        688      703      +15     
- Partials      257      260       +3

Impacted Files	Coverage Δ
src/garage/tf/algos/_rl2npo.py	`100.00% <ø> (ø)`
src/garage/tf/algos/erwr.py	`44.44% <ø> (ø)`
src/garage/tf/algos/ppo.py	`66.66% <ø> (ø)`
src/garage/tf/algos/rl2ppo.py	`100.00% <ø> (ø)`
src/garage/tf/algos/rl2trpo.py	`100.00% <ø> (ø)`
src/garage/tf/algos/te_ppo.py	`100.00% <ø> (ø)`
src/garage/tf/algos/tnpg.py	`72.72% <ø> (ø)`
src/garage/tf/algos/trpo.py	`100.00% <ø> (ø)`
src/garage/tf/algos/vpg.py	`72.72% <ø> (ø)`
src/garage/torch/algos/maml_ppo.py	`100.00% <ø> (ø)`
... and 35 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update f8aaef2...9ca6a91. Read the comment docs.

ryanjulian commented 3 years ago

Unfortunately, the only way to solve this is to fix the build under the new pip -- we have no control over which version of pip people use, and when in doubt we should use the latest.

yeukfu commented 3 years ago

Can you add a comment to setup.py explaining what's going on here? As is this change is pretty unclear.

Sure

rlworkgroup / garage

Resolve conflicts between mujoco-py and gym temporarily #2188

Codecov Report