rlworkgroup / garage

A toolkit for reproducible reinforcement learning research.
MIT License
1.86k stars 309 forks source link

Rework logic for filling and checking replay buffer in torch sac, dog, and td3 #2197

Open avnishn opened 3 years ago

avnishn commented 3 years ago

Currently in sac, train once returns none if the replay buffer doesn't have the minimum number of timesteps in it.

This function should still return some value or raise an exception.

ryanjulian commented 3 years ago

_train_once is either private, or should be private, so I'm not sure what purpose this exception would have.