rlworkgroup / garage

A toolkit for reproducible reinforcement learning research.
MIT License
1.86k stars 309 forks source link

Solve #2204 #2206

Closed ghost closed 12 months ago

ghost commented 3 years ago

Solve inconsistent usage between the definition and call of the function _sample_params in cem.py.

haydenshively commented 3 years ago

/ok-to-test

rlworkgroupbot commented 3 years ago

Command run output for https://github.com/rlworkgroup/garage/pull/2206/commits/f54edb2c1994c92582172a14965e83d8f0c7fcd2

haydenshively commented 3 years ago

@krzentner Can you please merge this?

ryanjulian commented 3 years ago

@haydenshively it needs to be rebased first

avnishn commented 3 years ago

@mergifyio rebase

mergify[bot] commented 3 years ago

Command rebase: success

Branch has been successfully rebased

avnishn commented 3 years ago

/ok-to-test

rlworkgroupbot commented 3 years ago

Command run output for https://github.com/rlworkgroup/garage/pull/2206/commits/24a5d40742ec8e27f3a9d1b42951cd2279d0275f

rlworkgroupbot commented 3 years ago

Command run output for https://github.com/rlworkgroup/garage/pull/2206/commits/24a5d40742ec8e27f3a9d1b42951cd2279d0275f

ziyiwu9494 commented 3 years ago

@Mergifyio rebase

mergify[bot] commented 3 years ago

Command rebase: success

Branch has been successfully rebased

ziyiwu9494 commented 3 years ago

/ok-to-test

rlworkgroupbot commented 3 years ago

Command run output for https://github.com/rlworkgroup/garage/pull/2206/commits/1e3672fcd100d878f5c2070c0b17fd21a65707fd

ziyiwu9494 commented 3 years ago

@os-popt Can you make sure the commit passes the pre-commit check? How to install and run pre-commit