search

rlworkgroup / garage

A toolkit for reproducible reinforcement learning research.
MIT License
1.86k stars 309 forks source link

Add command for running CI on PRs from forks #2229

Closed gitanshu closed 3 years ago

gitanshu commented 3 years ago

Secret variable are not accessible to the CI if the pull request repo head is a fork, so that a random fork can't access the secrets by logging them in the CI output. pull_request_target event has similar security issues.

This commit adds a workflow that allows somebody with write access to the repo to trigger the CI workflow with access to secrets, against the PR, by commenting /ok-to-test on that PR, after reviewing the code to make sure it is safe.

By default, it runs the workflow against the merge commit of the head of the PR and the target branch. Newer commits have to be tested by issuing the slash command again. It is also possible to test a specific commit using /ok-to-test sha=<commit_sha>.

codecov[bot] commented 3 years ago

Codecov Report

Merging #2229 (1f17425) into master (7ecab12) will decrease coverage by 0.64%. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2229      +/-   ##
==========================================
- Coverage   91.84%   91.19%   -0.65%     
==========================================
  Files         242      201      -41     
  Lines       17456    10977    -6479     
  Branches     2537     1371    -1166     
==========================================
- Hits        16033    10011    -6022     
+ Misses       1057      704     -353     
+ Partials      366      262     -104
Impacted Files Coverage Δ
src/garage/sampler/utils.py 0.00% <0.00%> (-77.05%) :arrow_down:
src/garage/torch/algos/pearl.py 48.64% <0.00%> (-31.00%) :arrow_down:
src/garage/envs/multi_env_wrapper.py 79.51% <0.00%> (-14.60%) :arrow_down:
src/garage/tf/policies/policy.py 77.77% <0.00%> (-13.53%) :arrow_down:
src/garage/sampler/env_update.py 82.92% <0.00%> (-13.08%) :arrow_down:
src/garage/tf/algos/erwr.py 44.44% <0.00%> (-12.70%) :arrow_down:
src/garage/experiment/task_sampler.py 75.86% <0.00%> (-7.58%) :arrow_down:
src/garage/np/_functions.py 77.39% <0.00%> (-7.01%) :arrow_down:
...rage/tf/optimizers/conjugate_gradient_optimizer.py 81.90% <0.00%> (-6.57%) :arrow_down:
src/garage/tf/_functions.py 68.85% <0.00%> (-5.98%) :arrow_down:
... and 149 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 7ecab12...1f17425. Read the comment docs.