search

rlworkgroup / garage

A toolkit for reproducible reinforcement learning research.
MIT License
1.86k stars 309 forks source link

Fix saving episodes #2235

Closed krzentner closed 3 years ago

krzentner commented 3 years ago

When we renamed trainer.step_episodes to trainer.step_path, another related refactor still used step_path, resulting in most algorithms failing to save episodes. This change fixes those algorithms.

krzentner commented 3 years ago

Please note that I have not tested this change yet.

codecov[bot] commented 3 years ago

Codecov Report

Merging #2235 (cf681ab) into master (8ac7e62) will decrease coverage by 0.64%. The diff coverage is 96.55%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2235      +/-   ##
==========================================
- Coverage   91.84%   91.19%   -0.65%     
==========================================
  Files         242      201      -41     
  Lines       17456    10977    -6479     
  Branches     2537     1371    -1166     
==========================================
- Hits        16032    10011    -6021     
+ Misses       1060      704     -356     
+ Partials      364      262     -102
Impacted Files Coverage Δ
src/garage/torch/algos/td3.py 94.44% <75.00%> (ø)
src/garage/np/algos/cem.py 100.00% <100.00%> (+0.89%) :arrow_up:
src/garage/np/algos/cma_es.py 100.00% <100.00%> (+1.06%) :arrow_up:
src/garage/tf/algos/ddpg.py 96.98% <100.00%> (+1.32%) :arrow_up:
src/garage/tf/algos/dqn.py 91.37% <100.00%> (-4.39%) :arrow_down:
src/garage/tf/algos/npo.py 96.44% <100.00%> (-0.15%) :arrow_down:
src/garage/tf/algos/reps.py 98.46% <100.00%> (+0.85%) :arrow_up:
src/garage/tf/algos/td3.py 96.62% <100.00%> (-1.65%) :arrow_down:
src/garage/tf/algos/te_npo.py 94.23% <100.00%> (-0.89%) :arrow_down:
src/garage/torch/algos/ddpg.py 96.63% <100.00%> (-0.26%) :arrow_down:
... and 161 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 8ac7e62...cf681ab. Read the comment docs.