rlworkgroup / garage

A toolkit for reproducible reinforcement learning research.
MIT License
1.86k stars 309 forks source link

Trainer.train(store_episodes=True) does not store episodes #2236

Closed AaEll closed 3 years ago

AaEll commented 3 years ago

Trainer.train(store_episodes=True)is meant to store episode trajectories in itr_0.pkl,itr_1.pkl, ..., but in the current implementation it does not.

The only side effect of store_episodes=True, is on line 443 of trainer.py: save_episode = (self.step_episode if self._train_args.store_episodes else None)

self.step_episode is then passed to self._stats and saved correctly.

However, self.step_episode is never set in most algorithms.