search

rlworkgroup / garage

A toolkit for reproducible reinforcement learning research.
MIT License
1.84k stars 309 forks source link

Reward should be float in EnvStep? #2261

Open Shushman opened 3 years ago

Shushman commented 3 years ago

https://github.com/rlworkgroup/garage/blob/f056fb8f6226c83d340c869e0d5312d61acf07f0/src/garage/_environment.py#L114

Based on the docstring, should that line not be reward: float ?

avnishn commented 3 years ago

Hi @Shushman,

I think that you're correct. But there my may be a reason for this.

@ziyiwu9494 could you please check this out?