search

rlworkgroup / garage

A toolkit for reproducible reinforcement learning research.
MIT License
1.84k stars 309 forks source link

Fix SetTaskEnvUpdate when new env is a supertype #2264

Closed krzentner closed 3 years ago

krzentner commented 3 years ago

Before, if the new environment was a subtype of the existing environment, the environment was not changed, even though it should be.

codecov[bot] commented 3 years ago

Codecov Report

Merging #2264 (8a3af71) into master (3fb4f50) will decrease coverage by 0.02%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2264      +/-   ##
==========================================
- Coverage   91.33%   91.30%   -0.03%     
==========================================
  Files         199      199              
  Lines       10977    10943      -34     
  Branches     1386     1379       -7     
==========================================
- Hits        10026     9992      -34     
+ Misses        694      693       -1     
- Partials      257      258       +1
Impacted Files Coverage Δ
src/garage/sampler/env_update.py 82.92% <100.00%> (ø)
src/garage/torch/_functions.py 94.16% <0.00%> (-1.29%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 3fb4f50...8a3af71. Read the comment docs.