search

rlworkgroup / garage

A toolkit for reproducible reinforcement learning research.
MIT License
1.84k stars 309 forks source link

implementation detail question about MAMLPPO #2331

Open seolhokim opened 1 year ago

seolhokim commented 1 year ago

Hi, Thank you for providing the quality code. I have a implementation detail question.

  1. Why don't you just call optimizer.step() after meta_objective.backward()?

https://github.com/rlworkgroup/garage/blob/f056fb8f6226c83d340c869e0d5312d61acf07f0/src/garage/torch/algos/maml.py#L124-L127