search

rly / ndx-pose

NWB extension to store pose estimation data
BSD 3-Clause "New" or "Revised" License
13 stars 11 forks source link

Initial implementation of a PoseTraining Group #9

Closed roomrys closed 1 year ago

roomrys commented 2 years ago

Description

Add PoseTraining group to store annotations for training a pose estimator.

Related Issues

rly commented 2 years ago

These changes look good to me, and I support @CBroz1 's changes. It would be good to get feedback from @bendichter and @AlexEMG on these changes before we proceed.

CBroz1 commented 1 year ago

Hi @roomrys, Hi @rly - I'd like to get this merged to use with a DataJoint NWB export. Should I open a separate PR to reflect the changes we discuss here?

roomrys commented 1 year ago

Hi @rly,

I believe all is ready! Please let me know if there is anything else that needs work.

talmo commented 1 year ago

Hey friends, where do we stand with this PR these days @rly @bendichter?

rly commented 1 year ago

Hi @talmo . Sorry for the extreme delay on wrapping up this PR... I will finalize this during the developer hackathon next week.

talmo commented 1 year ago

Let us know if there's anything we can help with! This is a key piece of functionality for us to be able to convert our hand labeled data for archival :)

rly commented 1 year ago

@roomrys Could you please enable edits to this PR / branch from maintainers? There should be a checkbox on the right side. I would like to give you credit for this PR if possible.

roomrys commented 1 year ago

Sorry @rly, it seems that is impossible at the moment https://github.com/orgs/community/discussions/5634

talmo commented 1 year ago

@rly what if you send a PR with your changes to talmolab:main, we merge it there, and then it updates here?

Or we could follow the above thread's response:

HELP! Please fix this, or we shall move to svn 🥲

😂😂

talmo commented 1 year ago

Or maybe add @roomrys as a maintainer to the repo? Or @roomrys add @rly as a maintainer to our fork so the checkbox works?

rly commented 1 year ago

Sounds good. Will do.

@rly what if you send a PR with your changes to talmolab:main, we merge it there, and then it updates here?

rly commented 1 year ago

Or maybe add @roomrys as a maintainer to the repo? Or @roomrys add @rly as a maintainer to our fork so the checkbox works?

I'll add @roomrys to the repo in case that helps but I think adding me to the fork would work.

rly commented 1 year ago

Sounds good. Will do.

@rly what if you send a PR with your changes to talmolab:main, we merge it there, and then it updates here?

It turns out that GitHub does not allow me to fork a fork of my repo.

image
rly commented 1 year ago

I will just merge this and make changes in a new PR. Thanks for the contribution @roomrys , @CBroz1 , and @CodyCBakerPhD !