search

rm-hull / luma.examples

Companion repo for running examples against the luma.oled, luma.lcd, luma.led_matrix and luma.emulator display drivers.
MIT License
370 stars 144 forks source link

add histogram example #103

Closed ghost closed 5 years ago

ghost commented 5 years ago

https://github.com/rm-hull/luma.examples/issues/102#issuecomment-473391918

I added a new file with my example system monitor

fixes #102

thijstriemstra commented 5 years ago

thanks @Tkopic001

The travis build process detected some cosmetic issues, like whitespace around operators etc. Can you take a look and remove that whitespace?

See https://travis-ci.org/rm-hull/luma.examples/jobs/506936035#L361 for details.

ghost commented 5 years ago

I'm not really sure what's going on, i've went trought the code 4 times removing all the spaces,

It runs fine on multiple machines:

  1. My PC
  2. OrangePI
  3. Cubieboard2

The details of the error look kinda strange: https://travis-ci.org/rm-hull/luma.examples/jobs/506953487

ghost commented 5 years ago

Oh, ok i see what's going on, i'm gonna fix it...

ghost commented 5 years ago

Well this was annoying, but i finally fixed it,

rm-hull commented 5 years ago

Happy to take it into the examples repo but I will make work the same as the other examples (i.e. using get_device, so that it works across different display types)

ghost commented 5 years ago

Sure, no problem, i'm happy you like it I would love to adapt this to be a bit more dynamic and work across multiple displays and resolutions but only have this one monochrome SSD1306 display :/

thijstriemstra commented 5 years ago

The other examples show how to use get_device and make it compatible with all devices.

thijstriemstra commented 5 years ago

Also add yourself to https://github.com/Tkopic001/luma.examples/blob/patch-1/CONTRIBUTING.rst

rm-hull commented 5 years ago

I made some small changes - it now works across a range of devices (inc. my mac), and we can use the luma.emulator devices now too:

luma_anim

rm-hull commented 5 years ago

can you also add it to the listing of examples in the docs?

Will do that directly on master