rm-hull / luma.lcd

Python module to drive PCD8544, HT1621, ST7735, ST7567 and UC1701X-based LCDs
https://luma-lcd.readthedocs.io
MIT License
156 stars 56 forks source link

Support for ili9488 displays #168

Closed wightmanjr closed 1 year ago

wightmanjr commented 1 year ago

Updated const.py and device.py to support ILI9488 displays.

thijstriemstra commented 1 year ago

thanks! couple of things; can you

let us know if you have any questions. See for example https://github.com/rm-hull/luma.lcd/commit/093e53fd753daf6927e22dfe7feca7cd552e7740 for a comprehensive driver addition.

wightmanjr commented 1 year ago

I will work on it. I'm somewhat new to python tests, but will figure it out as I go.

Thanks

thijstriemstra commented 1 year ago

thanks. also see https://github.com/rm-hull/luma.lcd/actions/runs/5232388084/jobs/9451907761#step:9:24 for some linter failures causing the build to fail.

wightmanjr commented 1 year ago
rm-hull commented 1 year ago

Aside @thijstriemstra's comments, looks fine to me

wightmanjr commented 1 year ago

Made changes @thijstriemstra requested.

thijstriemstra commented 1 year ago

@wightmanjr there are no new commits since my last review?

wightmanjr commented 1 year ago

Thanks for all the help, it was a great learning experience.