Closed wightmanjr closed 1 year ago
thanks! couple of things; can you
doc/tech-spec
directory?let us know if you have any questions. See for example https://github.com/rm-hull/luma.lcd/commit/093e53fd753daf6927e22dfe7feca7cd552e7740 for a comprehensive driver addition.
I will work on it. I'm somewhat new to python tests, but will figure it out as I go.
Thanks
thanks. also see https://github.com/rm-hull/luma.lcd/actions/runs/5232388084/jobs/9451907761#step:9:24 for some linter failures causing the build to fail.
Added name to CONTRIBUTING.rst
Updated documentation
Uploaded ILI9488 datasheet
Fixed flake errors
Updated gamma values
Added tests for ILI9488
Aside @thijstriemstra's comments, looks fine to me
Made changes @thijstriemstra requested.
@wightmanjr there are no new commits since my last review?
Thanks for all the help, it was a great learning experience.
Updated const.py and device.py to support ILI9488 displays.