search

rm-hull / luma.lcd

Python module to drive PCD8544, HT1621, ST7735, ST7567 and UC1701X-based LCDs
https://luma-lcd.readthedocs.io
MIT License
156 stars 56 forks source link

Added support for the 128x64 st7567 #71

Closed Gadgetoid closed 5 years ago

Gadgetoid commented 5 years ago

I've added support plus test coverage for the st7567 LCD driver. The driver chip itself can drive a variety of displays/orientations but is usually found paired with a 128x64 pixel, 1-bit LCD display (much like the st7565).

The display rotation is the default- with the black strip and ribbon cable at the top of the display- but can be rotated 180 degrees with --rotate 2.

90 and 270 degree rotation aren't so hot, though. Is there an established pattern for blocking these? An assert(rotate in [0,2]) seems a little clunky since it throws a not-particularly-friendly assertion error.

Gadgetoid commented 5 years ago

Oh and before this can be released, it looks like I need the .. versionadded:: X.X.X - should this be the currently released version +1? IE: 1.0.4 in this case?

rm-hull commented 5 years ago

Nice one ... I'll attend to this next week when I'm back off holidays

rm-hull commented 5 years ago

@Gadgetoid you could have a scan though the docs and add refernces to ST7567 where appropriate, eg. in:

It would be good to source a PDF datasheet and drop that into the https://github.com/rm-hull/luma.lcd/tree/master/doc/tech-spec and update the ref on the intro page too.

Other than that, implementation looks fine 👍

rm-hull commented 5 years ago

Oh and before this can be released, it looks like I need the .. versionadded:: X.X.X - should this be the currently released version +1? IE: 1.0.4 in this case?

I'll update when I cut a new release, but maybe just add a hardcoded .. versionadded:: X.X.X for now

rm-hull commented 5 years ago

Luma.LCD v1.1.0 released: