search

rm-hull / luma.lcd

Python module to drive PCD8544, HT1621, ST7735, ST7567 and UC1701X-based LCDs
https://luma-lcd.readthedocs.io
MIT License
156 stars 56 forks source link

Add a PWM backlight Control #99

Closed kevinastone closed 4 years ago

kevinastone commented 4 years ago

Allows a substitute PWM based backlight control in place of the digital GPIO control.

The existing RPi.GPIO doesn't support hardware PWM, so this isn't currently a strong solution without better support for alternative GPIO libraries such as pigpio. I'd recommend transitioning this library to gpiozero which provides better abstractions over the different GPIO libraries on the RasPi.

This is a follow-up to #95.

rm-hull commented 4 years ago

LGTM pending @thijstriemstra‘s comments 👍

thijstriemstra commented 4 years ago

can you also add some documentation for usage of these classes?

this was not addressed. can you add some usage docs in doc/python-usage.rst?

kevinastone commented 4 years ago

@thijstriemstra they're internal implementation helpers. Not really designed to be used by a developer. I'd consider them package private.

thijstriemstra commented 4 years ago

Ah I see! Thanks for the contribution.

rm-hull commented 4 years ago

I'll try and push out a new release to pypi shortly

rm-hull commented 4 years ago

https://pypi.org/project/luma.lcd/2.3.0/