rm-hull / luma.led_matrix

Python module to drive LED Matrices & 7-segment displays (MAX7219) and RGB NeoPixels (WS2812 / APA102)
https://luma-led-matrix.readthedocs.io
MIT License
523 stars 157 forks source link

remove redundant ws2812 package #264

Closed thijstriemstra closed 2 years ago

thijstriemstra commented 2 years ago

See https://github.com/rm-hull/luma.led_matrix/issues/260#issuecomment-980800315

fixes #260

thijstriemstra commented 2 years ago

could you please take a look @rm-hull? this issue is reported on a daily basis by new users.

rm-hull commented 2 years ago

just wondering if the ws2812 pypi package is a peer dependency of rpi_ws281x .. I will try and dig out my unicornhat and give it a blast, and if it still works we can gladly remove it

thijstriemstra commented 2 years ago

doesn't look like it: https://github.com/jgarff/rpi_ws281x/blob/master/python/setup.py

Also see https://github.com/rm-hull/luma.led_matrix/issues/260#issuecomment-980800315

Gadgetoid commented 2 years ago

rpi_ws2812 is a standalone port/binding of the rpi_ws281x C library.

ws2812 is a very old and forgotten port of https://github.com/626Pilot/RaspberryPi-NeoPixel-WS2812

ws2812 is safe to drop.

I should probably do something with ws2812...

thijstriemstra commented 2 years ago

can I help with something @rm-hull?