search

rm-hull / luma.oled

Python module to drive a SSD1306 / SSD1309 / SSD1322 / SSD1325 / SSD1327 / SSD1331 / SSD1351 / SH1106 OLED
https://luma-oled.readthedocs.io
MIT License
807 stars 161 forks source link

Fix mutable default parameter bug when using multiple displays #313

Closed rm-hull closed 3 years ago

rm-hull commented 3 years ago

See: https://github.com/rm-hull/luma.oled/issues/311#issuecomment-727635204

thijstriemstra commented 3 years ago

@rm-hull you left one instance unchanged, was this intentional? https://github.com/rm-hull/luma.oled/blob/master/luma/oled/device/__init__.py#L574

rm-hull commented 3 years ago

Yes, intentional... I did contemplate changing this one, but as the full-frame class doesn't have any mutable state, it seemed safe to leave it.