rmagatti / goto-preview

A small Neovim plugin for previewing definitions using floating windows.
Apache License 2.0
834 stars 27 forks source link

[BUG] incorrect floating window closed in case multiple floating previews are opened #116

Closed embe221ed closed 2 months ago

embe221ed commented 7 months ago

Describe the bug I noticed that the change implemented in #115 made neovim close incorrect floating preview window. In case I have two floating windows open, :q will close the second one instead of the current floating window.

To Reproduce Steps to reproduce the behavior:

  1. go-to definition preview
  2. from the floating window open another definition preview
  3. try to close the newest floating window

Expected behavior the currently focused floating window is closed

Screenshots If applicable, add screenshots to help explain your problem.

Baseline (please complete the following information):

embe221ed commented 7 months ago

commenting out the code from #115 fixes the issue for me

rmagatti commented 7 months ago

@Tebro have you experienced the issue above at all?

Tebro commented 7 months ago

I have not seen this, but I use <C-w>c to close windows. I however just tested using :q instead and I cannot reproduce.

rmagatti commented 6 months ago

For the record, I can't reproduce this either. I'm on MacOS and Neovim built from master.

rmagatti commented 2 months ago

Stale