search

rmagatti / gx-extended.nvim

Extending the use of Neovim's `gx`
MIT License
31 stars 3 forks source link

Update/fix default "packer-plugins.lua" extension and spellcheck/format README.md #15

Closed srikarg closed 1 year ago

srikarg commented 1 year ago

Hey @rmagatti, thank you for the great plugin!

This PR has the following changes:

  1. When using the default packer-plugins.lua extension that's built into this plugin, I noticed that only double quotes are replaced with an empty string before navigating to the plugin's Github URL. For my plugins file, I am using single quotes (i.e. { 'christoomey/vim-tmux-navigator', lazy = false, },), so this extension was incorrectly taking me to https://github.com/'christoomey/vim-tmux-navigator' instead of https://github.com/christoomey/vim-tmux-navigator. In my fix, I'm simply replacing both double AND single quotes like the example extension in the README.

    • I have tried using another custom extension like the README describes but this is resulting in the default packer-plugins.lua and my custom extension conflicting with each other as they both act on my plugins.lua file. I am using NVChad and it requires placing plugins in a plugins.lua file: https://nvchad.com/docs/config/plugins#manage_custom_plugins.

  2. I have also spell checked a few words and formatted the README.md, please let me know if any formatting is not desired and I can revert as needed.

rmagatti commented 12 months ago
  • I have tried using another custom extension like the README describes but this is resulting in the default packer-plugins.lua and my custom extension conflicting with each other as they both act on my plugins.lua file. I am using NVChad and it requires placing plugins in a plugins.lua file:

One thing, this should be prompting you with a vim.ui.select prompt, is it not?

srikarg commented 11 months ago

@rmagatti Yes, it is, but I figured the fix to check for both single/double quotes might help anyways given that it's a possibility in packer's configuration file as per here (I see some of the plugin dependency definitions surrounded in single quotes there like use 'rstacruz/vim-closer' for example).