Please return self instead of Qnil when the image did not meet the qualifier.

rmagick-temp / rmagick

An interface to the ImageMagick and GraphicsMagick image processing libraries.

http://rmagick.rubyforge.org/

MIT License

790 stars 102 forks source link

Please return self instead of Qnil when the image did not meet the qualifier. #130

Open fukuchi opened 9 years ago

fukuchi commented 9 years ago

Hi,

When I rotate an image with a qualifier and it was not qualified, rotate method returns Qnil. However, this breaks method chaining like this:

image.rotate(90, '>'),resize_to_fit(96,128) # causes 'undefined method' image.minify.rotate(90, '>') # if nil returned, all previous operations are lost

Why does it simply return self instead of nil? As far as I guess, no one needs to know whether it was rotated or not.

bf4 commented 9 years ago

Please close this issue as the repo has moved https://github.com/rmagick/rmagick/issues/120 At this time we do not have access to this repo.