search

rmagick / rmagick

Ruby bindings for ImageMagick
https://rmagick.github.io/
MIT License
694 stars 140 forks source link

Fix install error on Windows MINGW environment and drop Windows MSWIN environment support #1585

Closed Watson1978 closed 3 weeks ago

Watson1978 commented 3 weeks ago

Fix https://github.com/rmagick/rmagick/issues/1584

Previously ImageMagick provided CORE_RL_MagickCore_.lib where we statically resolve the symbols needed at build time. The latest version no longer provides that file.

This has forced us to modify the build process to resolve symbols using .dll files.

In a WINGW environment, dlls can be linked directly. However, in an MSWIN environment, a lib file is required to solve symbols or modify many source codes. I think almost all users use RubyInstaller (MINGW environment), so I will drop MSWIN support

This fix will be released as v5.6.0. After v5.6.0 is released, I let these changes to will be to the main branch as forward port.

Watson1978 commented 3 weeks ago

@mockdeep I am going to drop it as it is difficult to support MSWIN environment. Do you have any concerns?

Watson1978 commented 3 weeks ago

Seems it would be better to release these changes as v6.0. hmm...