search

rmaia / pavo

tools for the analysis of color data in R
http://pavo.colrverse.com
GNU General Public License v2.0
69 stars 17 forks source link

Refactor rspec wl isolation #163

Closed Bisaloo closed 4 years ago

Bisaloo commented 5 years ago

This is a first step to partially address #102.

Still a draft because I'd like to test for regressions before merging.

Only difference I noticed atm: plot.rspec(type = "stacked") labels will start at 1 instead of 2. I'm not sure what makes more sense. I can change this if necessary.

thomased commented 5 years ago

Could plotsmooth() just be rolled into a type option in plot.rspec()? e.g. type = 'smooth' or stacksmooth or something. I haven't played with it in a while, but I wonder if it really needs to be its own function.

Bisaloo commented 4 years ago

Could plotsmooth() just be rolled into a type option in plot.rspec()? e.g. type = 'smooth' or stacksmooth or something. I haven't played with it in a while, but I wonder if it really needs to be its own function.

Hmm, maybe, I'm not sure. Not totally against it. Only minor objection is that plotsmooth() is supposed to be used in the exploratory part of the analysis (to determine the best span value to smooth spectra), while plot.rspec() is usually used to create the final plots.

explorespec() is in a similar situation btw.